Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress deprecation of logicalAsInt #6646

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Progress deprecation of logicalAsInt #6646

merged 2 commits into from
Dec 30, 2024

Conversation

MichaelChirico
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.61%. Comparing base (0578714) to head (121a861).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6646      +/-   ##
==========================================
- Coverage   98.61%   98.61%   -0.01%     
==========================================
  Files          79       79              
  Lines       14557    14553       -4     
==========================================
- Hits        14356    14352       -4     
  Misses        201      201              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico MichaelChirico added this to the 1.17.0 milestone Dec 10, 2024
Copy link

github-actions bot commented Dec 10, 2024

Comparison Plot

Generated via commit 121a861

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 41 seconds
Installing different package versions 7 minutes and 39 seconds
Running and plotting the test cases 2 minutes and 16 seconds

@ben-schwen
Copy link
Member

LGTM TY

@ben-schwen ben-schwen merged commit 42aeddf into master Dec 30, 2024
9 checks passed
@ben-schwen ben-schwen deleted the logical-as-int-err branch December 30, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants